feat: support $ref #1208
feat: support $ref #1208
Conversation
| if (reachable.has(typeName)) { | ||
| // we've already processed this definition | ||
| const typeName = decodeURIComponent(definition.$ref.slice(DEFINITION_OFFSET)); | ||
| if (reachable.has(typeName) || !isLocalRef(definition.$ref)) { |
There was a problem hiding this comment.
I think this is too late. At this point we already generated the schema. It would be better to not even recurse into types when we have a ref.
There was a problem hiding this comment.
Good point. I'll look into it.
There was a problem hiding this comment.
I updated AnnotatedNodeParser such that it short-circuits child type parsing if an explicit ref annotation was provided.
Instead, it sets the child type to AnyType. The AnyType is conveniently represented as an empty object which means we'll only get the $ref property in the output schema and no additional noise coming from the type itself.
| nested: MyNestedObject | ||
|
|
||
| /** | ||
| * @ref http://json-schema.org/draft-07/schema# |
There was a problem hiding this comment.
Does json schema support additional properties here?
There was a problem hiding this comment.
I don't understand. What do you mean?
There was a problem hiding this comment.
Could you also add a comment here and see that in the description of the json schema property?
|
Thank you |
|
🚀 PR was released in |
github-actions
bot
added
released
fixes #1207
Version
Published prerelease version:
v1.1.0-next.0Changelog
🎉 This release contains work from a new contributor! 🎉
Thank you, Hadrien Milano (@hmil), for all your work!
🚀 Enhancement
🐛 Bug Fix
@description#1177 (@Jason3S)🔩 Dependency Updates
Authors: 4